Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Remove double quotes in RBAC manifests #573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented Aug 7, 2024

There were a few cases where we used double-quotes for verbs, but most
of the manifest is written without them. This is just a consistency fix
so they're all the same.

There were a few cases where we used double-quotes for verbs, but most
of the manifest is written without them. This is just a consistency fix
so they're all the same.
@rhmdnd
Copy link
Author

rhmdnd commented Aug 7, 2024

Adding various -approved labels since this is a trivial fix and mostly cosmetic.

@rhmdnd rhmdnd requested review from Vincent056 and removed request for jhrozek August 7, 2024 12:57
Copy link

github-actions bot commented Aug 7, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:573

@rhmdnd rhmdnd added this to the 1.6.0 milestone Aug 9, 2024
@rhmdnd
Copy link
Author

rhmdnd commented Aug 28, 2024

@Vincent056 @yuumasato this should be an easy one to kick through.

@rhmdnd rhmdnd modified the milestones: 1.6.0, 1.6.1 Oct 11, 2024
Copy link

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuumasato
Copy link
Member

/test e2e-rosa

@yuumasato
Copy link
Member

/retest

@yuumasato
Copy link
Member

/retest-required

Copy link

openshift-ci bot commented Dec 5, 2024

@rhmdnd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-rosa db98688 link true /test e2e-rosa

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants