-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Remove double quotes in RBAC manifests #573
base: master
Are you sure you want to change the base?
🧹 Remove double quotes in RBAC manifests #573
Conversation
There were a few cases where we used double-quotes for verbs, but most of the manifest is written without them. This is just a consistency fix so they're all the same.
Adding various -approved labels since this is a trivial fix and mostly cosmetic. |
🤖 To deploy this PR, run the following command:
|
@Vincent056 @yuumasato this should be an easy one to kick through. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-rosa |
/retest |
/retest-required |
@rhmdnd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There were a few cases where we used double-quotes for verbs, but most
of the manifest is written without them. This is just a consistency fix
so they're all the same.