Only update scan StartTimestamp when launching

[yuumasato]

Only set the StartTimestamp when the scan transitions to LAUNCHING phase.
When on PENDING state it doesn't have any timestamp.

This avoids setting the scan timestamp twice in succession.
It was being set once when transitioning to PENDING, and then once again when transitioning to LAUNCHING.

[github-actions]

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:619-37f4354227d0884596cca88ac51976f551cf272d

[yuumasato]

@lvalerom This should fix the double setting of the scan timestamp. Could you try with this build?

[openshift-ci]

@yuumasato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-rosa	37f4354	link	true	/test e2e-rosa

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[lvalerom]

Could you try with this build?

@yuumasato I've tested this change with the profiles ocp4-cis and ocp4-cis-node and it seems to have fixed the issue.
Thank you!

[Vincent056]

/lgtm
Thanks for the fix

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Vincent056, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Vincent056,yuumasato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xiaojiey]

/label qe-approved
Verification pass with CATALOG_IMG ghcr.io/complianceascode/compliance-operator-catalog:619-37f4354227d0884596cca88ac51976f551cf272d