Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(council-update): OpenGov-Soon-council-change #4110

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

JafarAz
Copy link
Collaborator

@JafarAz JafarAz commented Sep 1, 2023

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 23 4h 55m 6
blasrodri 17 2h 22m 6
mina86 14 14h 52m 44
kkast 10 2h 31m 6
vmarkushin 5 7h 2
RustNinja 5 1h 33m 0
JafarAz 3 9h 25m 0
0xBrainjar2 2 3d 17h 35m 6

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4110/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4110/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4110/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4110/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4110/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@JafarAz JafarAz added the Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform label Sep 1, 2023
@JafarAz JafarAz changed the title docs(council-members-update): OpenGov-Soon docs(council-update): OpenGov-Soon Sep 2, 2023
@JafarAz JafarAz changed the title docs(council-update): OpenGov-Soon docs(council-update): OpenGov-Soon-council-change Sep 4, 2023
@JafarAz JafarAz enabled auto-merge September 4, 2023 16:24
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

stale-pr

@github-actions github-actions bot added the Stale-item bot: Stale PRs and issues handling #owned:terraform label Sep 9, 2023
Copy link
Contributor

@fl-y fl-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JafarAz JafarAz merged commit 866f40b into main Sep 11, 2023
35 checks passed
@JafarAz JafarAz deleted the update-council-members branch September 11, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform Stale-item bot: Stale PRs and issues handling #owned:terraform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants