feat(xcvm): rework protocol messages [breaking change] #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4116/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4116/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed # CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4116/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed # run cross chain devnet with Dotsama and Cosmos nodes
nix run "github:ComposableFi/composable/refs/pull/4116/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4116/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh |
|
@dzmitry-lahoda, thoughts? Not sure how far gone the deployment of the contracts has gone. With this contracts would need to be updated and re-deplayed with any old messages no longer being valid. |
dzmitry-lahoda
previously approved these changes
Sep 6, 2023
|
@dzmitry-lahoda, PTAL. Had to resolve conflicts. |
|
@dzmitry-lahoda, friendly ping. |
Required for merge: - [ ] `pr-workflow-check / draft-release-check` is ✅ success - Other rules GitHub shows you, or can be read in [configuration](../terraform/github.com/branches.tf) Makes review faster: - [ ] PR title is my best effort to provide summary of changes and has clear text to be part of release notes - [ ] I marked PR by `misc` label if it should not be in release notes - [ ] Linked Zenhub/Github/Slack/etc reference if one exists - [ ] I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description - [ ] Added reviewer into `Reviewers` - [ ] I tagged(`@`) or used other form of notification of one person who I think can handle best review of this PR - [ ] I have proved that PR has no general regressions of relevant features and processes required to release into production - [ ] Any dependency updates made, was done according guides from relevant dependency - Clicking all checkboxes - Adding detailed description of changes when it feels appropriate (for example when PR is big)
9 tasks
dzmitry-lahoda
approved these changes
Sep 10, 2023
|
Uh? GitHub seems confused:
@dzmitry-lahoda, could you try approving again? |
dzmitry-lahoda
approved these changes
Sep 11, 2023
blasrodri
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is a breaking change. Protobuf message definition as
well as serde definition of XCVM program and packets are changed.
Simplify protobuf definitions by removing wrapping types. It’s not
protobuf style to have messages with just one flied (such as AssetId)
where instead the field can be used directly. Removing those shortens
the protocol buffer and removes some of the conversion code.
Replace Self, Tip, Result and IpRegister BindingValues with
a single registry field and a corresponding Registry enum. This
mirrors the way Rust types are defined and again simplifies conversion
code.
Rename
idtoexchange_idin instruction::Exchange andnetworkto
network_idin instruction::Spawn. This makes it more consistentwith protobuf messages as well as other types which use
foo_idforidentifier fields. This change affects serde.
Rename handful of fields in protobuf from camelCase to snake_case
as per the protobuf style guide. This doesn’t change the Rust code.
Required for merge:
pr-workflow-check / draft-release-checkis ✅ successMakes review faster:
misclabel if it should not be in release notesReviewers@) or used other form of notification of one person who I think can handle best review of this PR