Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork upgrade client #244

Merged
merged 9 commits into from
Sep 29, 2023
Merged

Fork upgrade client #244

merged 9 commits into from
Sep 29, 2023

Conversation

vuong177
Copy link
Contributor

Fork upgrade for unfreeze 08-wasm client

Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR is not marked as a draft, I proceeded with the review. I requested some changes and comments. Also, please fix the failing workflow actions.

app/upgrades/v5_2_0/constants.go Outdated Show resolved Hide resolved
app/upgrades/v5_2_0/constants.go Outdated Show resolved Hide resolved
}
}

func UpdateWasmContract(ctx sdk.Context, ibckeeper *ibckeeper.Keeper, wasmKeeper wasm08keeper.Keeper) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove wasmKeeper receiving param as it is not used for the function

@vuong177 vuong177 merged commit 8fdba09 into master Sep 29, 2023
7 of 8 checks passed
tungleanh0902 pushed a commit to notional-labs/composable-cosmos that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants