changed the instructions to make it less ambiguous #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I ran this, I thought the "Explore a much more robust address derivation application at iancoleman.io" meant that the code that follows is optional. Turns out it did not mean that of course. But it's understandable I thought that since the previous steps were all instructions followed by code. To make things more in line with the precedent, I have moved the "explore ..." line above and added a simple instruction to add the code to the file. Hope this helps someone else like me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ran this, I thought the "Explore a much more robust address derivation application at iancoleman.io" meant that the code that follows is optional. Turns out it did not mean that of course. But it's understandable I thought that since the previous steps were all instructions followed by code.
To make things more in line with the precedent, I have moved the "explore ..." line above and added a simple instruction to add the code to the file.
Hope this helps someone else like me