Added uint256 type as valid type for price and sku #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uint is an alias for uint256, and many people use uint256 instead the alias because they prefer uint256 for some cases or for readability. OpenZeppelin uses uint256 instead of uint: - ERC20 OpenZeppelin: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/ERC20.sol - ERC721 OpenZeppelin https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC721/ERC721.sol Example when uint256 could be better: 1. bytes4(keccak('transfer(address, uint)')) you'll get a different method sig ID than 2. bytes4(keccak('transfer(address, uint256)')) I thing that an smart contract only understands the second (uint256) case if it is comparing meth. signature Ids both, uint and uint256 are valids, so I thing both of types should be valid in the test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uint is an alias for uint256, and many people use uint256 instead the alias because they prefer uint256 for some cases or for readability.
OpenZeppelin uses uint256 instead of uint:
Example when uint256 could be better:
you'll get a different method sig ID than
I thing that an smart contract only understands the second (uint256) case if it is comparing meth. signature Ids
both, uint and uint256 are valids, so I thing both of types should be valid in the test cases