Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Do not fail gradle javadoc task on javadoc comments warnings #531

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

usmansaleem
Copy link
Contributor

PR Description

Java 17 enforces several javadoc comments warnings which results in EthSigner javadoc task to be failed (called during publish task). This PR updates javadoc task to not fail on reported javadoc comments warnings.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@usmansaleem usmansaleem changed the title D not fail gradle javadoc task on javadoc warnings Do not fail gradle javadoc task on javadoc comments warnings Oct 18, 2023
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usmansaleem usmansaleem merged commit 8f02e28 into Consensys:master Oct 18, 2023
4 checks passed
@usmansaleem usmansaleem deleted the javadoc_fix branch October 18, 2023 04:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants