HIR Syntax for Modules #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The basics of schema-level modules are now in place, and we have two tests added for them. The outstanding problem is that of alignment. Specifically, trace and schema module alignment. Its not clear to me this should be significant. However, there is an issue whereby a schema module index is being used (during alignment) to determine the correct column index.
This fixes an issue with alignment whereby modules exist in the schema, but not in the trace. This can arise in valid circumstances. For example, when a module is declared which doesn't contain any columns. Another situation is the prelude module, which is always declared regardless of whether or not any columns are declared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts in place HIR syntax for modules, and updates
Schemato properly support modules. However, there only relatively limited well-formedness checks at this stage.