feat: initial support for corset syntax
#382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this stage, there remains quite a lot to do. However, it is at least starting to make sense.
At the moment, am trying to sort out the issue of updating a source file map for the structured representation.
This pushes through various changes to support the compilation of multiple files at a time. At this stage, most existing tests are still failing since the Corset parser is not at all fleshed out.
The parser now supports a more useful range of expression forms, and the defconstraint declaration. That's enough to do something useful, and hence the next step is to focus on the compiler itself.
First baby steps towards a proper name resolution process.
The next steps are: (1) make sure we have proper source map info for expressions; (2) check invalid constraints.
Now, need to sort out source mapping of expressions.
Resolution of column names is now working, and reporting correct syntax errors.
There appears to be an issue, however, with the evaluation of interleaving columns. This might be caused by an incorrect allocation of columns, but that doesn't make sense to me.
Furthermore, the general resolution process for assignments appears to be working as well. However, there are outstanding issues around the order in which input columns / assignments are allocated.
This addresses the issue related to the order in which assignments and input columns are declared. Previously, there was a problem whereby the process could end up with the wrong identifiers. Fixed now.
This adds support for column types, including those with the @prove annotation. This also updates most of the tests to be syntactically valid, and comments out only those which are using a sorted permutation.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts in place initial support for parsing and compiling
corsetconstraint files. In particular, compilation is separated out from HIR and uses an explicit resolution phase. More is needed though, such as type checking and context checking. Furthermore, support for missing syntax (e.g. arrays, functions, etc) is needed.