Chore: testing on local stack #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ethers.namehash("eth") | ||
| ); | ||
| const baseRegistrarAddress = await baseRegistrar.getAddress(); | ||
| await baseRegistrar.addController(signerL1Address).then((tx) => tx.wait()); |
There was a problem hiding this comment.
across the files there is a mix of syntax which should be standardised
await tx.wait();
vs.
.then((tx) => tx.wait())
There was a problem hiding this comment.
This is a small simplification to have a one liner instead of:
let tx = await baseRegistrar.addController(signerL1Address);
await tx.await();
There was a problem hiding this comment.
I know, we should just be consistent with the approach we take - at present it is mixed
There was a problem hiding this comment.
I just made the change
VGau
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run the resolver e2e tests on the local stack run:
aggregation-proofs-limitinconfig/coordinator/coordinator-docker.config.tomltoaggregation-proofs-limit=15make fresh-start-allcd packages/linea-ens-resolver/pnpm ipnpm test:local