Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out pause manager types for cleaner code breakdown #124

Open
5 tasks
thedarkjester opened this issue Oct 1, 2024 · 0 comments
Open
5 tasks

Split out pause manager types for cleaner code breakdown #124

thedarkjester opened this issue Oct 1, 2024 · 0 comments
Assignees
Labels
Contracts Smart Contract related

Comments

@thedarkjester
Copy link
Collaborator

thedarkjester commented Oct 1, 2024

Description

Split out pause manager types for cleaner code breakdown.

Motivation

Upon reevaluation, it made more sense from a code size, and code cleanliness perspective to split out the particular pause roles and types for the LineaRollup, L2MessageService and the TokenBridge.

Previously it was designed to not have multiple versions for each contract to simplify management, but the granularity dictates the need to split it out.

Tasks

  • Separate the inherited PauseManager to be specific for each of the specified contracts

Acceptance criteria

  • LineaRollup does not contain any L2MessageService or TokenBridge types or roles
  • L2MessageService does not contain any LineaRollup or TokenBridge types or roles
  • TokenBridge does not contain any L2MessageService or LineaRollup types or roles

Risks

  • Overlaps of types could cause confusion, but it is cleaner and specific to each deploy
@thedarkjester thedarkjester added the Contracts Smart Contract related label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contracts Smart Contract related
Projects
None yet
Development

No branches or pull requests

2 participants