Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Refactor pause manager structure #126

Merged
merged 14 commits into from
Oct 4, 2024

Conversation

VGau
Copy link
Collaborator

@VGau VGau commented Oct 2, 2024

This PR implements issue(s) #124

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@VGau VGau requested a review from a team as a code owner October 2, 2024 09:11
Copy link

github-actions bot commented Oct 2, 2024

Delta Summary - Kotlin Code Coverage

Generated on: 10/03/2024 - 07:58
Description Previous Current Delta
Coverage date: 10/03/2024 - 07:58 10/03/2024 - 07:58
Tag: 652_11158030739 652_11158030739
Line coverage: 27.3% 27.3% 0.0%
Covered lines: 25666 25666 0
Coverable lines: 93723 93723 0
Total lines: 132974 132974 0
Branch coverage: 10.4% 10.4% 0.0%
Covered branches: 5527 5527 0
Total branches: 52680 52680 0
Method coverage: Feature is only available for sponsors

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.70%. Comparing base (2db07df) to head (acbc988).

Files with missing lines Patch % Lines
contracts/contracts/lib/PermissionsManager.sol 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main     #126       +/-   ##
=============================================
+ Coverage     67.82%   98.70%   +30.88%     
=============================================
  Files           248       34      -214     
  Lines         10389      925     -9464     
  Branches        867      216      -651     
=============================================
- Hits           7046      913     -6133     
+ Misses         2875       12     -2863     
+ Partials        468        0      -468     
Flag Coverage Δ
hardhat 98.70% <96.77%> (?)
kotlin ?
Files with missing lines Coverage Δ
contracts/contracts/LineaRollup.sol 98.75% <100.00%> (ø)
contracts/contracts/lib/PauseManager.sol 100.00% <100.00%> (ø)
...s/contracts/messageService/l1/L1MessageService.sol 100.00% <100.00%> (ø)
...tracts/messageService/l1/v1/L1MessageServiceV1.sol 100.00% <100.00%> (ø)
...s/contracts/messageService/l2/L2MessageManager.sol 100.00% <100.00%> (ø)
...s/contracts/messageService/l2/L2MessageService.sol 100.00% <100.00%> (ø)
...tracts/messageService/l2/v1/L2MessageManagerV1.sol 100.00% <ø> (ø)
...tracts/messageService/l2/v1/L2MessageServiceV1.sol 100.00% <100.00%> (ø)
contracts/contracts/tokenBridge/TokenBridge.sol 100.00% <100.00%> (ø)
contracts/contracts/lib/PermissionsManager.sol 87.50% <50.00%> (ø)

... and 272 files with indirect coverage changes

@VGau VGau merged commit efbec20 into main Oct 4, 2024
11 of 16 checks passed
@VGau VGau deleted the feat/refactor-pause-manager-structure branch October 4, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants