Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABI encoding type for inline arrays #223

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

blitz-1306
Copy link
Contributor

Preface

This PR tweaks InferType.toABIEncodedType() to produce ABI typestring, that is consumable by web3s ABI encoder.

Changes

  • Remove branch, causing inline arrays to have tuple type as ABI encoding type.

Regards.

@blitz-1306 blitz-1306 added the bug Something isn't working label Oct 5, 2023
@blitz-1306 blitz-1306 changed the title Fix ABI encoing type for inline arrays Fix ABI encoding type for inline arrays Oct 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #223 (adc5f1c) into master (68aa8ca) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   91.74%   91.81%   +0.07%     
==========================================
  Files         267      267              
  Lines        6551     6546       -5     
  Branches     1320     1319       -1     
==========================================
  Hits         6010     6010              
+ Misses        287      283       -4     
+ Partials      254      253       -1     
Files Coverage Δ
src/types/infer.ts 83.03% <ø> (+0.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cd1m0 cd1m0 merged commit f467859 into master Oct 5, 2023
2 checks passed
@cd1m0 cd1m0 deleted the fix-type-inference-of-fixed-arrays branch October 5, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants