Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of OverrideSpecifier.vOverrides to comply with type of child nodes #236

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

blitz-1306
Copy link
Contributor

No description provided.

@blitz-1306 blitz-1306 added the bug Something isn't working label Nov 8, 2023
@blitz-1306 blitz-1306 requested a review from cd1m0 November 8, 2023 05:39
@blitz-1306
Copy link
Contributor Author

Overall, this fix should be more extensive, as we should tweak ASTNodeWithChildren to respect children type T more properly (ownChildren should be of type T instead of ASTNode, all relevant methods should be tuned).

@codecov-commenter
Copy link

Codecov Report

Merging #236 (8cd0be3) into master (a7344e5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #236   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         267      267           
  Lines        6630     6630           
  Branches     1353     1353           
=======================================
  Hits         6073     6073           
  Misses        291      291           
  Partials      266      266           
Files Coverage Δ
src/ast/implementation/meta/override_specifier.ts 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@cd1m0 cd1m0 merged commit 4b08187 into master Nov 10, 2023
2 checks passed
@cd1m0 cd1m0 deleted the fix-override-spec branch November 10, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants