Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom compilers in solc-typed-ast versions #273

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

cd1m0
Copy link
Contributor

@cd1m0 cd1m0 commented Sep 16, 2024

This pr adds support for custom compiler paths in solc-typed-ast. To use a custom compiler you can specify a verison such as "custom:/":

sol-ast-compile --compiler-kind native --compiler-version 'custom:/path/to/solc' file.sol

@cd1m0 cd1m0 self-assigned this Sep 16, 2024
Copy link
Contributor Author

@cd1m0 cd1m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 75.67568% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.72%. Comparing base (e92fc59) to head (a9c0045).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/compile/kinds/compiler.ts 85.71% 4 Missing ⚠️
src/compile/version.ts 57.14% 3 Missing ⚠️
src/types/infer.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   91.11%   93.72%   +2.60%     
==========================================
  Files         270      270              
  Lines        6503     6513      +10     
  Branches     1320     1322       +2     
==========================================
+ Hits         5925     6104     +179     
+ Misses        469      386      -83     
+ Partials      109       23      -86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cd1m0 cd1m0 merged commit aadcbb3 into master Sep 16, 2024
3 checks passed
@cd1m0 cd1m0 deleted the custom.version branch September 16, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants