Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update snap demo html #160

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

stanleyyconsensys
Copy link
Collaborator

refactor Snap demo html to:

  1. easier to add new method by adding new method into a array formWithSubmit with form id and handler
const formWithSubmit = [
      ...,
      {
        id: 'new form',
        method: methodHandler,
      },
]
  1. reusable method callSnap to interacting with snap
//e.g
await callSnap(
    'starkNet_signMessage', //snap method name
    { typedDataMessage, signerAddress }, //params
);

Copy link

sonarcloud bot commented Nov 6, 2023

[consensys_starknet-snap-starknet-snap] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

sonarcloud bot commented Nov 6, 2023

[consensys_starknet-snap-wallet-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@stanleyyconsensys stanleyyconsensys merged commit b53cc7f into main Nov 7, 2023
5 checks passed
@stanleyyconsensys stanleyyconsensys deleted the feat/refactor-snap-demo-html branch November 7, 2023 09:02
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
This was referenced Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants