Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multi transaction to snap #161

Merged
merged 8 commits into from
Nov 10, 2023
Merged

feat: add multi transaction to snap #161

merged 8 commits into from
Nov 10, 2023

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Nov 6, 2023 •
edited
Loading

  • add multi transaction method starknet_executeTxn to snap
  • allow to review transaction by using snap dialog with copyable txt on senderAddress, txnInvocation, abis, invocationsDetails (invocationsDetails will decouple into nonce, maxFee, version to display)
  • method input interface will be extend from starknet.js method execute
  • method output interface will be extend from starknet.js method execute
  • add lint:fix option

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner November 6, 2023 05:42
wantedsystem
wantedsystem previously approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@wantedsystem wantedsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 10, 2023

[consensys_starknet-snap-starknet-snap] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.4% 75.4% Coverage
3.7% 3.7% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 10, 2023

[consensys_starknet-snap-wallet-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@stanleyyconsensys stanleyyconsensys enabled auto-merge (squash) November 10, 2023 01:48
@stanleyyconsensys stanleyyconsensys merged commit eaee37b into main Nov 10, 2023
5 checks passed
@stanleyyconsensys stanleyyconsensys deleted the feat/multi-transaction branch November 10, 2023 01:49
@github-actions github-actions bot mentioned this pull request Nov 10, 2023
Merged
This was referenced Nov 26, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantedsystem wantedsystem wantedsystem left review comments

@Julink-eth Julink-eth Awaiting requested review from Julink-eth Julink-eth is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyyconsensys @wantedsystem