Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(SNAP): refactor starkNet_getCurrentNetwork api #396

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor(SNAP): refactor starkNet_getCurrentNetwork api #396

wants to merge 2 commits into from

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Oct 21, 2024 •
edited
Loading

This PR is to refactor starkNet_getCurrentNetwork api

and only return the network name and chainId as response

Due to below params are no longer valid

  • baseUrl,
  • nodeUrl,
  • voyagerUrl,
  • accountClassHash,
  • useOldAccounts

BEGIN_COMMIT_OVERRIDE
feat: Refactor RPC starkNet_getCurrentNetwork to return the network chainId and name only
END_COMMIT_OVERRIDE

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner October 21, 2024 08:50
@stanleyyconsensys stanleyyconsensys requested review from Akaryatrh and jonesho and removed request for a team October 21, 2024 08:50
khanti42
khanti42 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stanleyyconsensys stanleyyconsensys marked this pull request as draft November 4, 2024 12:46
@stanleyyconsensys stanleyyconsensys self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanti42 khanti42 khanti42 approved these changes

@Akaryatrh Akaryatrh Awaiting requested review from Akaryatrh Akaryatrh is a code owner automatically assigned from Consensys/snaps-factory-reviewers

@jonesho jonesho Awaiting requested review from jonesho jonesho is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees

@stanleyyconsensys stanleyyconsensys

Labels
not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyyconsensys @khanti42