Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors when OpenSSL is installed in non-standard place #280

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

koprok
Copy link

@koprok koprok commented Jan 16, 2019

No description provided.

@mvdwerve
Copy link
Contributor

This does not compile if OPENSSL_INCLUDE_DIR was not defined.

Can you define it by default?

The checks failed - for more info go to https://travis-ci.org/CopernicaMarketingSoftware/AMQP-CPP/jobs/480295985

@koprok
Copy link
Author

koprok commented Jan 16, 2019

@mvdwerve, I saw that it does not compile on the build server, but I still don't understand why. The find_path() call should set OPENSSL_INCLUDE_DIR if there is openssl/ssl.h header on the system. It looks like this header is missing. But then, how does the code compile (before my changes) as it includes this header.

@mvdwerve
Copy link
Contributor

No idea, I'm going to check this out locally to see if it works there, and otherwise I'll fix the build file because then there is probably some error there.

mvdwerve added a commit that referenced this pull request Jan 17, 2019
@koprok
Copy link
Author

koprok commented Jan 17, 2019

@mvdwerve, it works locally on my own system and also when building through Vcpkg (https://github.com/koprok/vcpkg/commits/amqpcpp). Actually Vcpkg build is the reason I have added this patch - because amqpcpp has to find and use the OpenSSL headers from Vcpkg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants