Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version header with AMQPCPP_VERSION preprocessor symbol #496

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Chardrazle
Copy link

A bit of cmake machinery that stamps out a "version.h" file based on the existing values in CMakeLists.txt.
The version_template.h file is used to construct the version header. The initial "version.h" file is created in the build (binary) dir so as not to pollute the source tree. It is installed into ".../include/amqpcpp/".

@EmielBruijntjes
Copy link
Member

What would the recommended workflow be when we bring out a new version? Currently, after I brought out a new version, I already (manually) update the version numbers in Makefile and CMakeLists.txt to prepare for the next version.

@Chardrazle
Copy link
Author

Does anything change?
Presumably at the point where you’ve decided the release is ready, that’s the snapshot point where the values in the make files truly represent that version (as opposed to working towards).
You then set the tag to mark it. After that you update the values for the next targeted version.
If I were to download, say, v4.3.20, the VERSION_XYZ values in its CMakeLists.txt file specify 4, 3 and 20. So a cmake, make, make install will always be bound to those values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants