Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhoneNumber library #52

Merged
merged 8 commits into from
Dec 18, 2023
Merged

PhoneNumber library #52

merged 8 commits into from
Dec 18, 2023

Conversation

woodseowl
Copy link
Collaborator

@woodseowl woodseowl commented Oct 3, 2023

Adds a library class for phone number validation and formatting utilities.

This PR does the following

  • Adds PhoneNumber library class (see README.md for details)
  • Introduces the idea of using the Starter Kit as a library package and documents that usage

To Review:

Notes

  • The test coverage is mostly just cases that have been encountered over the years in Daily Check, but they also demonstrate usage.

@woodseowl woodseowl marked this pull request as ready for review October 16, 2023 20:00
Copy link
Contributor

@richmarisa richmarisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All very tidy.

@woodseowl woodseowl merged commit b55f4ab into main Dec 18, 2023
2 checks passed
@woodseowl woodseowl deleted the phone-library branch December 18, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants