Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LdapData helper #55

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

LdapData helper #55

wants to merge 4 commits into from

Conversation

woodseowl
Copy link
Collaborator

A helper for retrieving Cornell University LDAP data. Based on the legacy App\Helpers\LDAP::data() class that exists on various Cornell Laravel sites.

This PR does the following

  • Adds src\Ldap\LdapData for retrieving data from LDAP
  • Adds src\Ldap\LdapDataServiceProvider to provide default configuration
  • Updates .env.example with required LDAP variables
  • Documentation and rudimentary testing

To Review:

  • Review README file additions to assess usage
  • Review how the LDAP data is normalized in src\Ldap\LdapData::make(). This was based on a comparison of approaches applied in DailyCheck, IT Gov, and EMNPhone. (Improvements and alternate use case requirements welcome!)

Notes
The testing fixtures are real data from LDAP that I scrubbed of personal identifiers. I felt that this rudimentary testing was necessary to assure that we don't break how we retrieve this data that users will see as very personal.

@woodseowl woodseowl changed the base branch from main to phone-library October 17, 2023 17:35
Base automatically changed from phone-library to main December 18, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant