Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added update_url to json to avoid corrupted extension message on Chrome 63+ #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BoxOfSnoo
Copy link

I mentioned this in an issue. Here's a simple fix

@Cortys
Copy link
Owner

Cortys commented Aug 30, 2018

Hi! Thanks for the PR.

I'm not able to reproduce the issue this fixes, so I'm currently holding back on merging. As far as I know, the corruption warning only occurs when installing crx files. Since this extension is not released as a crx this does not apply though.

Could you describe how you are able produce this issue?

@sgbeal
Copy link

sgbeal commented Aug 30, 2018

i was getting this error at some point, too (installing "unpacked" from the source tree), but it hasn't happened to me in any recent updates, so it seems that that may have been a short-lived bug in Chrome/Chromium (it's conceivable that that version/those versions may still be the latest versions on some Linux distros).

@BoxOfSnoo
Copy link
Author

I think @sgbeal is right. I was getting this even when using "unpacked" with Chrome 63 back when I created the PR. It doesn't seem to happen now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants