Stat Analysis Implementation #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…global-workflow into feature/anlstat
| @@ -1,6 +1,7 @@ | |||
| #! /usr/bin/env bash | |||
|
|
|||
| source "${HOMEgfs}/ush/preamble.sh" | |||
| export DATA=${DATA:-${DATAROOT}/${RUN}statanl_${cyc}} | |||
There was a problem hiding this comment.
This is only needed if we intend on changing the path for DATA from the default
parm/config/gfs/config.analstat
Outdated
| # Get task specific resources | ||
| source "${EXPDIR}/config.resources" anlstat | ||
|
|
||
| echo "END: config.anlstat" |
There was a problem hiding this comment.
nearly duplicate file? probably needs removed
| @@ -5,7 +5,7 @@ | |||
| import os | |||
|
|
|||
| from wxflow import Logger, cast_strdict_as_dtypedict | |||
| from pygfs.task.atm_analysis import AtmAnalysis | |||
| from pygfs.task.stat_analysis import StatAnalysis | |||
There was a problem hiding this comment.
We should change to using the new Jedi class
sorc/link_workflow.sh
Outdated
| @@ -252,7 +252,7 @@ fi | |||
| #------------------------------ | |||
| if [[ -d "${HOMEgfs}/sorc/gdas.cd" ]]; then | |||
| cd "${HOMEgfs}/parm/gdas" || exit 1 | |||
| declare -a gdasapp_comps=("aero" "atm" "io" "ioda" "snow" "soca" "jcb-gdas" "jcb-algorithms") | |||
| declare -a gdasapp_comps=("aero" "atm" "io" "ioda" "snow" "soca" "stats" "jcb-gdas" "jcb-algorithms") | |||
There was a problem hiding this comment.
thinking about this more, I think we just need snow/stats, soca/stats, aero/stats, atm/stats, rather than a stats dir
| logger = getLogger(__name__.split('.')[-1]) | ||
|
|
||
|
|
||
| class StatAnalysis(Analysis): |
There was a problem hiding this comment.
see comment above about that we should migrate to the new Jedi class
kevindougherty-noaa
force-pushed
the
feature/anlstat
branch
from
85f8877 to
1563594
Compare
|
Outdated and replaced by PR #8. Closing.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at adding stat analysis script to copy appropriate stat files.