Document SnapshotItem #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
uint
force-pushed
the
storage-plus-snapshot
branch
from
ef29c5a to
c33d600
Compare
uint
force-pushed
the
storage-plus-snapshot
branch
from
c33d600 to
3e8e06b
Compare
uint
force-pushed
the
storage-plus-snapshot
branch
from
3e8e06b to
426df27
Compare
chipshort
reviewed
Aug 13, 2024
I had exchange rates in mind (and yeah, that probably wasn't clear), but would it be more natural to go with integers? |
|
Anyway, I'll change it one way or another. |
|
I think decimals are fine, just wouldn't refer to them as "x%" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.