Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasmd section #88

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Add wasmd section #88

merged 5 commits into from
Jul 29, 2024

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Jul 5, 2024 •
edited
Loading

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jul 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmwasm-docs ✅ Ready (Inspect) Visit Preview ✅ 5 resolved Jul 29, 2024 10:53am

@pinosu pinosu marked this pull request as ready for review July 25, 2024 12:27
@pinosu pinosu changed the title 🚧 Add wasmd section Add wasmd section Jul 25, 2024
@pinosu pinosu requested a review from hashedone July 25, 2024 12:27
hashedone
hashedone reviewed Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general there is much I like there, but I feel like the examples are not really explained, jus put them (not all of them, some). I left couple comments, but there are more instances of the very same issue in there that I didn't repeat comments about.

@pinosu pinosu force-pushed the add_wasmd_section branch from b6e8552 to 347c2aa Compare July 29, 2024 10:23
hashedone
hashedone approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks far better!

@pinosu pinosu force-pushed the add_wasmd_section branch from 347c2aa to e73f063 Compare July 29, 2024 10:51
@pinosu pinosu merged commit 61201ce into main Jul 29, 2024
5 checks passed
@pinosu pinosu deleted the add_wasmd_section branch July 29, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone hashedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinosu @hashedone