Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testifylint #587

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

testifylint #587

wants to merge 7 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 22, 2024 •
edited
Loading

This PR lints using testifylint.

There will be other PR's based on it.

@webmaster128 please try to figure out what to do with mockinfobin. I really don't know. You should be able to push to my branch, if not, feel free to just make another PR.

@faddat
Copy link
Contributor Author

faddat commented Dec 22, 2024 •
edited
Loading 

=== RUN   TestGetMetrics
    lib_test.go:440: 
                Error Trace:    /Users/faddat/swappable-vm/internal/api/lib_test.go:440
                Error:          Not equal: 
                                expected: 0x0
                                actual  : 0x1
                Test:           TestGetMetrics

is the only remaining issue. I think I hit this when refactoring to use wazero also.

@faddat faddat mentioned this pull request Dec 22, 2024
Open
@faddat faddat changed the title testifylint execpt for the MockInfoBin testifylint Dec 22, 2024
@faddat faddat mentioned this pull request Dec 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@faddat