Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda activate fix and development environment #665

Merged
merged 25 commits into from
Oct 29, 2024

Conversation

sfarrens
Copy link
Member

@sfarrens sfarrens commented Nov 8, 2023

Summary

closes #651

Reviewer Checklist

Reviewers should tick the following boxes before approving and merging the PR.

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

@sfarrens sfarrens added bug Something isn't working enhancement New feature or request labels Nov 8, 2023
@sfarrens sfarrens added this to the ShapePipe v1.1.0 Release milestone Nov 8, 2023
@sfarrens sfarrens self-assigned this Nov 8, 2023
@sfarrens sfarrens marked this pull request as draft November 9, 2023 08:39
@sfarrens sfarrens mentioned this pull request Oct 21, 2024
12 tasks
@sfarrens
Copy link
Member Author

Hi @martinkilbinger, after discussing with @cailmdaley we decided to move towards a Conda-free distribution of ShapePipe. Therefore, I think this PR can be merged as it is to have a stable installation with passing CI in the develop branch. Don't be scared by the number of changed files as this just because I have moved everything into a src directory to better fit the current community standard.

The default environment.yml has not been properly checked, but this will be dropped soon anyway. Anyone wishing to install ShapePipe in the meantime can just install the development environment.

./install_shapepipe --env-dev

If all looks good to you, we can merge and @cailmdaley can create a new branch from develop.

LICENSE Outdated Show resolved Hide resolved
environment-dev.yml Outdated Show resolved Hide resolved
@sfarrens sfarrens marked this pull request as ready for review October 29, 2024 13:23
@sfarrens sfarrens merged commit 2b75551 into develop Oct 29, 2024
2 checks passed
@sfarrens sfarrens deleted the 651-conda-activate-fix branch October 29, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Bugs in Conda activation command set up
2 participants