CGS Update (part 1) #3018
Merged
CGS Update (part 1) #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice code |
|
add a bool or smth to do this, dont do it directly, approved ig 👍🏻 |
|
done!@ |
|
Okay, its ready! |
valentinbreiz
approved these changes
May 12, 2024
|
Thanks for the contribution :) |
may i ask why? it should always be done, you shouldnt have a bool to enable a bug fix i dont think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes
-Fixed VBE positioning bug issue #3009
-SVGAII & VBE - The bug with things going off screen has been fixed
-SVGAII - Fixed draw filled rectangles going also off screen. it was already fixed in vbe.
Warning: fixing off screen left side will be added in part 2 unless someone wants to do it first ;p