DA#304: BugFix: Incorrect filter definition bug

src/commands/documents/filterDocuments.ts

@@ -2,8 +2,8 @@ import CollectionNode from "../../model/CollectionNode";
 import * as vscode from "vscode";
 import { Memory } from "../../util/util";
 import { IFilterDocuments } from "../../types/IFilterDocuments";
-import { Commands } from "../extensionCommands/commands";
 import { logger } from "../../logger/logger";
+import { ParsingFailureError } from "couchbase";
 
 export const filterDocuments = async (node: CollectionNode) => {
     // Check if indexes are present for collection
@@ -32,7 +32,7 @@ export const filterDocuments = async (node: CollectionNode) => {
             logger.error("Error checking primary index: " + err);
             return false;
         });
-    if(!primaryIndexExists){
+    if (!primaryIndexExists) {
         return;
     }
 
@@ -65,6 +65,21 @@ export const filterDocuments = async (node: CollectionNode) => {
     if (newDocFilterStmt === undefined) {
         return;
     }
+    try {
+        if (newDocFilterStmt.trim() !== "") {
+            await node.connection.cluster?.query(`SELECT META().id FROM \`${node.bucketName}\`.\`${node.scopeName}\`.\`${collectionName}\` WHERE ${newDocFilterStmt}`);
+        }
+    } catch (err) {
+        if (err instanceof ParsingFailureError) {
+            vscode.window.showErrorMessage(
+                "Parsing Failed: Incorrect filter definition"
+            );
+        } else {
+            logger.error(err);
+        }
+        return;
+    }
+
     const newDocFilter: IFilterDocuments = {
         filter: newDocFilterStmt.trim(),
     };

src/model/CollectionNode.ts

@@ -20,14 +20,15 @@ import { INode } from "../types/INode";
 import DocumentNode from "./DocumentNode";
 import { PagerNode } from "./PagerNode";
 import { abbreviateCount } from "../util/common";
-import { PlanningFailureError } from "couchbase";
+import { ParsingFailureError, PlanningFailureError } from "couchbase";
 import InformationNode from "./InformationNode";
 import { Memory } from "../util/util";
 import { IFilterDocuments } from "../types/IFilterDocuments";
 import { SchemaDirectory } from "./SchemaDirectory";
 import { getActiveConnection } from "../util/connections";
 import { Commands } from "../commands/extensionCommands/commands";
 import { IndexDirectory } from "./IndexDirectory";
+import { logger } from "../logger/logger";
 
 export default class CollectionNode implements INode {
   constructor(
@@ -130,6 +131,8 @@ export default class CollectionNode implements INode {
           }
         );
         documentList.push(infoNode);
+      } else if (err instanceof ParsingFailureError) {
+        logger.error(`In Collection Node: ${this.collectionName}: Parsing Failed: Incorrect filter definition`);
       }
     }
     result?.rows.forEach((documentName: string) => {

src/model/ScopeNode.ts

@@ -23,7 +23,7 @@ import { IFilterDocuments } from "../types/IFilterDocuments";
 import CollectionNode from "./CollectionNode";
 import { logger } from "../logger/logger";
 import InformationNode from "./InformationNode";
-import { PlanningFailureError } from "couchbase";
+import { ParsingFailureError, PlanningFailureError } from "couchbase";
 
 export class ScopeNode implements INode {
   constructor(
@@ -84,8 +84,8 @@ export class ScopeNode implements INode {
             vscode.window.showErrorMessage(
               "Unable to find primary index for document and filter seems to be applied, showing count as 0"
             );
-          } else {
-            throw new Error(err);
+          } else if (err instanceof ParsingFailureError) {
+            logger.error(`In Scope Node: ${this.scopeName}: Parsing Failed: Incorrect filter definition`);
           }
         }