Some fixes for view duration and added tests #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arifBurakDemiray
approved these changes
Oct 14, 2024
CountlyTests/CountlyViewTests.swift
Outdated
| wait(for: [pauseViewExpectation, resumeViewExpectation], timeout: 10) | ||
| } | ||
|
|
||
| func testViewTrackingWithBackgroundAndForegroundNotifications() throws { |
There was a problem hiding this comment.
addition of test comments would be great
arifBurakDemiray
requested changes
Oct 22, 2024
CountlyTests/CountlyViewTests.swift
Outdated
| } | ||
|
|
||
| wait(for: [expectation], timeout: 5.0) // Wait for the expectation to be fulfilled | ||
| checkRecordedEventsForView(viewName: "View1") |
There was a problem hiding this comment.
you may also want to validate duration of the views
CountlyTests/CountlyViewTests.swift
Outdated
| resumeViewExpectation.fulfill() | ||
| } | ||
| wait(for: [expectation], timeout: 5.0) // Wait for the expectation to be fulfilled | ||
| checkRecordedEventsForView(viewName: "View1", segmentation: ["key": "value"]) |
There was a problem hiding this comment.
for example here. View must have a duration of 4 secondo
CountlyTests/CountlyViewTests.swift
Outdated
| NotificationCenter.default.post(name: UIApplication.didBecomeActiveNotification, object: nil) | ||
| fgExpectation.fulfill() | ||
| wait(for: [expectation], timeout: 5.0) // Wait for the expectation to be fulfilled | ||
| checkRecordedEventsForView(withID: viewID) |
There was a problem hiding this comment.
we want to see specifically also those durations are validated and SDK correctly calculates the duration
AliRKat
approved these changes
Oct 29, 2024
turtledreams
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.