Feedback improvements with new interface and new methods for ease of use #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
| @@ -1,3 +1,9 @@ | |||
| ## x.x.x | |||
| * Added `CountlyFeedbacks` interface to manage feedback widgets, including NPS, Surveys, and Ratings. | |||
| * `presentNPS`, `presentSurvey`, and `presentRating` methods now allow displaying specific widgets by name, ID, or tag. | |||
There was a problem hiding this comment.
it is great but mb we could add function signatures with class only not with parameter names like
presentNPS(String)
There was a problem hiding this comment.
i understand why @arifBurakDemiray is suggesting that but current version also feels totally fine to me
- Renaming files shows lots of changes, due to which its hard to review
AliRKat
suggested changes
Oct 22, 2024
CHANGELOG.md
Outdated
| @@ -1,3 +1,9 @@ | |||
| ## x.x.x | |||
| * Added `CountlyFeedbacks` interface to manage feedback widgets, including NPS, Surveys, and Ratings. | |||
| * `presentNPS`, `presentSurvey`, and `presentRating` methods now allow displaying specific widgets by name, ID, or tag. | |||
There was a problem hiding this comment.
i understand why @arifBurakDemiray is suggesting that but current version also feels totally fine to me
AliRKat
approved these changes
Oct 22, 2024
turtledreams
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.