Skip to content

Commit

Permalink
Merge pull request #181 from Cray-HPE/CASMCMS-8697-support
Browse files Browse the repository at this point in the history
CASMCMS-8697: Mark status/error and status/end_time string fields as nullable in API spec
  • Loading branch information
mharding-hpe authored Jun 29, 2023
2 parents 886de03 + 305e792 commit 5e2c729
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.0.24] - 2023-06-29
### Added
- Marked BOS v2 session status `error` and `end_time` fields as `nullable` in API spec, because they begin
populated with null values (rather than empty string values). Added comment to description text for these
fields to explain this.

## [2.0.23] - 2023-06-26
### Added
- Updated the API spec to:
Expand Down
8 changes: 7 additions & 1 deletion api/openapi.yaml.in
Original file line number Diff line number Diff line change
Expand Up @@ -1093,17 +1093,21 @@ it=999 spire_join_token=${SPIRE_JOIN_TOKEN}"
When the session was created.
end_time:
type: string
nullable: true
description: |
When the session completed.
A null value means the session has not ended.
status:
type: string
enum: ['pending', 'running', 'complete']
description: |
The status of a session.
error:
type: string
nullable: true
description: |
Error which prevented the session from running
Error which prevented the session from running.
A null value means the session has not encountered an error.
additionalProperties: false
V2BootSet:
description: |
Expand Down Expand Up @@ -1346,8 +1350,10 @@ it=999 spire_join_token=${SPIRE_JOIN_TOKEN}"
When the session was created.
end_time:
type: string
nullable: true
description: |
When the session completed.
A null value means the session has not ended.
duration:
type: string
description: |
Expand Down

0 comments on commit 5e2c729

Please sign in to comment.