Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMCMS-8451: Fail sessions that specify nodes that are not in the tenant #228

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

rbak-hpe
Copy link
Contributor

@rbak-hpe rbak-hpe commented Oct 27, 2023

Summary and Scope

Sessions that specify nodes in the node list that are not available to that tenant will now fail with an appropriate error message and the list of bad nodes.

  • Only nodes in the node_list are considered. groups and roles containing other nodes are still considered valid and will just filter out the invalid nodes
  • There is no error if the limit includes invalid nodes. The limit is a way of filtering down nodes and cannot add nodes so it is not considered to be requesting a specific node.

Also fixes some grammar in other error messages

Issues and Related PRs

  • Resolves CASMCMS-8451

Testing

Tested on:

  • mug

Test description:

Tested sessions with valid and invalid nodes

Risks and Mitigations

None

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@rbak-hpe rbak-hpe requested a review from a team as a code owner October 27, 2023 15:30
CHANGELOG.md Outdated Show resolved Hide resolved
@rbak-hpe rbak-hpe merged commit d7e3299 into develop Dec 4, 2023
6 checks passed
@rbak-hpe rbak-hpe deleted the CASMCMS-8451 branch December 4, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants