CASMCMS-8944: Reduce superfluous S3 calls during BOSv2 session creation #259
+15
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the BOS v2 session-setup operator is operating on a session with a large number of nodes, it ends up making a lot of S3 calls unnecessarily. The calls to S3 depend only on the boot sets in the session, but the current code makes the calls once per node, even if all the nodes belong to the same boot set.
This PR changes it so that the boot sets are parsed for this just once, rather than once per node.
I've tested these changes on wasp.
https://jira-pro.it.hpe.com:8443/browse/CASMCMS-8944
Backports:
#260
#261