CASMTRIAGE-7019: BOS reporter RPM: Add bos.common dependency, remove __pycache__ #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpdavis-prof
approved these changes
May 30, 2024
mharding-hpe
requested review from
rbak-hpe,
jsl-hpe,
jsollom-hpe,
dlaine-hpe and
juliansmit-hpe
mharding-hpe
added a commit
that referenced
this pull request
May 30, 2024
…9-1717095902 [chore] master -> develop from PR #319 (casmtriage-7019)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my recent code changes started making a call to
bos.commonfrom BOS reporter. Turns out we don't package upbos.commoninto the BOS reporter RPM. This PR corrects that (and also stops including the large superfluous__pycache__files inside the RPM).This will be backported to CSM 1.5.2 and CSM 1.4.5 as well.
I verified on starlord that this modification results in the necessary
bos.commonmodule being included in the RPM.