Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging CASMCMS-9039 fix into master #335

Merged
merged 10 commits into from
Jul 12, 2024
Merged

Merging CASMCMS-9039 fix into master #335

merged 10 commits into from
Jul 12, 2024

Conversation

jsollom-hpe
Copy link
Contributor

@jsollom-hpe jsollom-hpe commented Jul 11, 2024

Summary and Scope

Summarize what has changed. Explain why this PR is necessary. What is impacted? Is this a new feature, critical bug fix, etc?

Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

  • Resolves [issue id](issue link)
  • Change will also be needed in <insert branch name here>
  • Future work required by [issue id](issue link)
  • Documentation changes required in [issue id](issue link)
  • Merge with/before/after <insert PR URL here>

Testing

List the environments in which these changes were tested.

Tested on:

  • <development system>
  • Local development environment
  • Virtual Shasta

Test description:

How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?
  • Were continuous integration tests run? If not, why?
  • Was upgrade tested? If not, why?
  • Was downgrade tested? If not, why?
  • Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations

Are there known issues with these changes? Any other special considerations?

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@jsollom-hpe jsollom-hpe self-assigned this Jul 11, 2024
@jsollom-hpe jsollom-hpe requested a review from a team as a code owner July 11, 2024 19:46
@mharding-hpe
Copy link
Contributor

I added in a commit to fix a minor (and uncontroversial) bug that I just found.

@jsollom-hpe jsollom-hpe merged commit a4c125f into master Jul 12, 2024
8 of 9 checks passed
mharding-hpe added a commit that referenced this pull request Jul 15, 2024
…0371

[chore] master -> develop from PR #335 (develop)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants