CASMCMS-9161: Correct type hint, change Enum to IntEnum to allow inequalities #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharding-hpe
force-pushed
the
casmcms-9161
branch
from
9bb3fb4 to
2115e7d
Compare
jsollom-hpe
approved these changes
Oct 10, 2024
…equality comparison of same in sessions controller
mharding-hpe
force-pushed
the
casmcms-9161
branch
from
2115e7d to
60fc17b
Compare
mharding-hpe
added a commit
that referenced
this pull request
Oct 10, 2024
…728574831 [chore] master -> develop from PR #380 (casmcms-9161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes 3 changes:
validate_boot_setsfunction. The elements of the tuple were accidentally reversed.BootSetStatusclass fromEnumtoIntEnum. This gives the ability to perform inequalities between twoBootSetStatusobjects.2.0.31that removed an inequality betweenBootSetStatusobjects; it was generating an exception when it was anEnum, but that is no longer an issue, so may as well restore the code to how it was before.I tested this on mug.