CASMCMS-9225: Do not use itertools.batched #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake in the backports for CSM 1.4 and CSM 1.5 yesterday. I didn't modify the code to account for the fact that
itertools.batchedis not available in the Python version BOS uses in those releases.We already handle this same thing in
src/bos/operators/base.py, where we use that function in CSM 1.6, but use an alternative for previous CSM releases. This PR makes the same adjustment to the redis DB utility code which usesbatchedin CSM 1.6.I tested this on
baldarand verified that it fixes the issue, passes basic BOS tests, and shows no signs of other issues.