Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade label issue with latest bitnami chart (CASMPET-6831) #36

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

bklei
Copy link
Contributor

@bklei bklei commented Nov 1, 2023

Summary and Scope

Fix upgrade issue with bitnami etcd chart (introduction of new label).

Issues and Related PRs

  • CASMPET-6831: bitnami CSM 1.6 base chart upgrade fails due to immutable statefulset field(s)

Testing

beau

pit:~/brad # loftsman ship --manifest-path ./manifest-new.yaml --charts-path ./helm
2023-11-01T21:06:27Z INF Initializing the connection to the Kubernetes cluster using KUBECONFIG (system default), and context (current-context) command=ship
2023-11-01T21:06:27Z INF Initializing helm client object command=ship
         |\
         | \
         |  \
         |___\      Shipping your Helm workloads with Loftsman
       \--||___/
  ~~~~~~\_____/~~~~~~~

2023-11-01T21:06:27Z INF Ensuring that the loftsman namespace exists command=ship
2023-11-01T21:06:27Z INF Loftsman will use the packaged charts at ./helm as the Helm install source command=ship
2023-11-01T21:06:27Z INF Running a release for the provided manifest at ./manifest-new.yaml command=ship

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Releasing cray-etcd-test v1.1.1
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

2023-11-01T21:06:27Z INF Running helm install/upgrade with arguments: upgrade --install cray-etcd-test helm/cray-etcd-test-1.1.1.tgz --namespace services --create-namespace --set global.chart.name=cray-etcd-test --set global.chart.version=1.1.1 chart=cray-etcd-test command=ship namespace=services version=1.1.1
2023-11-01T21:07:04Z INF Release "cray-etcd-test" has been upgraded. Happy Helming!
NAME: cray-etcd-test
LAST DEPLOYED: Wed Nov  1 21:06:28 2023
NAMESPACE: services
STATUS: deployed
REVISION: 2
TEST SUITE: None
 chart=cray-etcd-test command=ship namespace=services version=1.1.1
2023-11-01T21:07:04Z INF Ship status: success. Recording status, manifest to configmap loftsman-brad in namespace loftsman command=ship
2023-11-01T21:07:04Z INF Recording log data to configmap loftsman-brad-ship-log in namespace loftsman command=ship
pit:~/brad # pod=cray-etcd-test-pre-upgrade-etcd-backup-6pq7w

pit:~/brad # kubectl -n services logs $pod -f
Creating /snapshots/cray-etcd-test-bitnami-etcd directory for snapshots...
Changing ownership of /snapshots/cray-etcd-test-bitnami-etcd to etcd user
No resources found in services namespace.
Ensuring cray-etcd-test-bitnami-etcd members have 'app.kubernetes.io/component=etcd' label for bitnami 9.x chart upgrade...
Adding label to cray-etcd-test-bitnami-etcd-0
pod/cray-etcd-test-bitnami-etcd-0 labeled
Adding label to cray-etcd-test-bitnami-etcd-1
pod/cray-etcd-test-bitnami-etcd-1 labeled
Adding label to cray-etcd-test-bitnami-etcd-2
pod/cray-etcd-test-bitnami-etcd-2 labeled
Deleting statefulset for cray-etcd-test-bitnami-etcd allowing helm to recreate
statefulset.apps "cray-etcd-test-bitnami-etcd" deleted
cray-etcd-test-857cbfdb9f-7gg6j                                   2/2     Running                 0             13m
cray-etcd-test-857cbfdb9f-dxvbk                                   2/2     Running                 0             13m
cray-etcd-test-857cbfdb9f-mswv4                                   2/2     Running                 0             13m
cray-etcd-test-bitnami-etcd-0                                     2/2     Running                 0             2m6s
cray-etcd-test-bitnami-etcd-1                                     2/2     Running                 0             3m16s
cray-etcd-test-bitnami-etcd-2                                     2/2     Running                 0             4m28s
cray-etcd-test-bitnami-etcd-snapshotter-28314540-zmms4            0/2     Completed               0             11m
cray-etcd-test-etcd-post-install-gfck6                            0/1     Completed               0             5m
cray-etcd-test-pre-upgrade-etcd-backup-z7ppf                      0/1     Completed               0             5m11s
cray-etcd-test-wait-for-etcd-2-vwwzl                              0/1     Completed               0             5m1s

Was a fresh Install tested? N
Was an Upgrade tested? N - N/A
Was a Downgrade tested? N - N/A
If schema changes were part of this change, how were those handled in your upgrade/downgrade testing? N/A

Risks and Mitigations

Low

Requires:

  • Nothing

@bklei bklei force-pushed the CASMPET-6831-1.6 branch 4 times, most recently from 0e3eafa to 3c787c8 Compare November 1, 2023 20:55
@bklei bklei marked this pull request as ready for review November 1, 2023 21:13
@bklei bklei requested a review from a team as a code owner November 1, 2023 21:13
@bklei bklei requested a review from mitchty November 2, 2023 15:44
@bklei bklei merged commit 2612c61 into master Nov 2, 2023
5 of 9 checks passed
leliasen-hpe pushed a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants