Casmpet 6876 release 1.5 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
When bitnami-etcd has a configuration file, it ignores all other environment variables that are normally used for etcd configuration. To fix this, this PR puts environment variables into the configuration file. Previously, we had noticed etcd filling up because auto-compaction-retention and auto-compaction-mode were not being set. These variables will now be put in the configuration file and etcd is performing much better.
Issues and Related PRs
Testing
List the environments in which these changes were tested.
Tested on:
Test description:
On lemondrop, cray-power-control-bitnami-etcd was deployed with this change that puts the environment variables in the configuration file. It was observed that etcd was in a good state after multiple days of running. Normally, it would have been full after only a couple of days.
On Beau, I deployed a cray-etcd-test chart that had these changes. I observed that it installed successfully and upgraded successfully when upgrading from the previous version of this chart. Note, I did not test an upgrade from the CSM 1.4 version of etcd to this version of bitnami-etcd in CSM 1.5.
Risk
I did not test an upgrade from CSM 1.4 etcd with an operator to this new version of CSM 1.5 bitnami-etcd. However, I would not expect this change to have any problems during an upgrade.
Pull Request Checklist