Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMPET-6904 update the cert-manager API in etcd-base chart #40

Merged
merged 12 commits into from
May 21, 2024

Conversation

leliasen-hpe
Copy link
Contributor

@leliasen-hpe leliasen-hpe commented May 16, 2024

Summary and Scope

In CSM 1.6, cert-manger is being upgraded to v1.12.9. This means the cert-manager.io/v1alpha2 api is being removed. Cray-etcd-base chart needs to be updated to use cert-manager.io/v1.

Testing

I tested deploying the cray-etcd-test chart on Beau.

My initial test, showed that the chart failed to deploy when the API was not updated. This is expected since that API has disappeared.

ncn-m001:~ # helm upgrade -n services cray-etcd-test cray-etcd-test-1.0.2-20240516143337+7a5adb9.tgz
Error: UPGRADE FAILED: [resource mapping not found for name: "cray-etcd-test-etcd-server-tls" namespace: "" from "": no matches for kind "Certificate" in version "cert-manager.io/v1alpha2"

My second test showed that I had changed the API in the certificate.yaml file incorrectly. The chart failed to deploy when I had written organization instead of organizations.

ncn-m001:~ # helm upgrade -n services cray-etcd-test cray-etcd-test-1.0.2-20240516150033+c271959.tgz.1
Error: UPGRADE FAILED: error validating "": error validating data: ValidationError(Certificate.spec.subject): unknown field "organization" in io.cert-manager.v1.Certificate.spec.subject

Finally, the chart deployed successfully showing that the certificate.yaml file was correct.

ncn-m001:~ # helm install -n services cray-etcd-test cray-etcd-test-1.0.2-20240516154808+1249b76.tgz
NAME: cray-etcd-test
LAST DEPLOYED: Thu May 16 15:50:43 2024
NAMESPACE: services
STATUS: deployed
REVISION: 1
TEST SUITE: None

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@leliasen-hpe leliasen-hpe requested a review from a team as a code owner May 16, 2024 13:25
@leliasen-hpe leliasen-hpe marked this pull request as draft May 16, 2024 14:21
@leliasen-hpe leliasen-hpe marked this pull request as ready for review May 16, 2024 15:57
Copy link

@dborman-hpe dborman-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have the v1alpha2 -> v1 changes manually applied and running on sigma7

@leliasen-hpe leliasen-hpe merged commit 3e88101 into master May 21, 2024
6 of 10 checks passed
@leliasen-hpe leliasen-hpe deleted the CASMPET-6904 branch May 21, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants