-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASMPET-6904 update the cert-manager API in etcd-base chart #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborman-hpe
reviewed
May 16, 2024
dborman-hpe
reviewed
May 16, 2024
dborman-hpe
reviewed
May 16, 2024
dborman-hpe
reviewed
May 16, 2024
dborman-hpe
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have the v1alpha2
-> v1
changes manually applied and running on sigma7
bo-quan
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
In CSM 1.6, cert-manger is being upgraded to v1.12.9. This means the cert-manager.io/v1alpha2 api is being removed. Cray-etcd-base chart needs to be updated to use cert-manager.io/v1.
Testing
I tested deploying the cray-etcd-test chart on Beau.
My initial test, showed that the chart failed to deploy when the API was not updated. This is expected since that API has disappeared.
My second test showed that I had changed the API in the certificate.yaml file incorrectly. The chart failed to deploy when I had written
organization
instead oforganizations
.Finally, the chart deployed successfully showing that the
certificate.yaml
file was correct.Pull Request Checklist