-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASMPET-6863: Document how to get past a statefulset error when doing a helm rollback #5619
Conversation
b3f25ca
to
9f15cc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nitpicky question; otherwise, great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving PR with a few minor adjustments.
… a helm rollback from a service chart with etcd bitnami 9.x to a chart with etcd bitnami 8.x.
85d25cb
to
f607338
Compare
Description
CASMPET-6863: Document how to get past a statefulset error when doing a helm rollback from a service chart with etcd bitnami 9.x to a chart with etcd bitnami 8.x.
If rolling back a service with bitnami etcd, the
helm rollback
could fail when going from an etcd chart version 9.x.x to an etcd chart version 8.x.x. This is because the bitnami 9.x etcd cluster statefulset and pods have theapp.kubernetes.io/component=etcd
label and the bitnami 8.x etcd cluster statefulset and pods do not, causing the statefulset to complain on rollback.This documents how to determine if the bitnami label mismatch is the cause of the
helm rollback
failure and how to run the new scriptremove_label_from_etcd_cluster.sh
. The script was taken and modified from theetcd-base-chart
pre-upgrade hook to remove the label rather than add the label.Testing
Did a bunch of testing on
beau
with thecray-etcd-test
chart contained incray-etcd
repo. Installed via helm acray-etcd-test
chart using etcd chart version 8.9.0 and then upgraded to acray-etcd-test
chart using version 9.5.6. Once upgrade complete, ranhelm rollback
to the previous version to recreate the statefulset error. Ran theremove_label_from_etcd_cluster.sh
script and then re-ranhelm rollback
successfully.Also, installed
cray-hms-hmnfd-3.0.2
chart onbeau
which already was runningcray-hms-hmnfd-4.0.4
and didhelm rollback
s between the versions to recreate the error, run the script, and have thehelm rollback
succeed.Checklist
.github/CODEOWNERS
with the corresponding team in Cray-HPE.