Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMHMS-6146: Generate correct PowerCapURI for Olympus hardware #29

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

jwlv
Copy link
Contributor

@jwlv jwlv commented Mar 10, 2024

Summary and Scope

PCS has been using the older /Power redfish URL to generate PowerCapURI for /Controls.Deep on all Olympus hardware. The issue with that is that newer hardware (eg. Blanca Peak, Parry Peak) no longer have the /Power URL. The fix here is to take one of the Controls URLs (eg. /Controls/NodePowerLimit) and use it to construct the PowerCapURI for /Controls.Deep. For simplicity and clarity in the code, the fix does this for all Olympus hardware even though older hardware still have the /Power URL.

Additionally, two health checks in the power cap path were converted to check for this newly constructed PowerCapURI rather than key off the older /Power URL that no longer exists.

Adopted app version 2.2.0 for CSM 1.5 (helm chart 2.0.7)
Adopted app version 2.2.0 for CSM 1.6 (helm chart 2.1.4)

Issues and Related PRs

  • Resolves CASMHMS-6146

Testing

Tested on tyr against the Windom, Bard Peak, Blanca Peak, and Parry Peak platforms.

For Windom, Blanca Peak, and Parry Peak I set and cleared a power cap for "Power Node Limit"

For Bard Peak I set and cleared a power cap for "Accelerator3 Power Limit"

I also verified that I could set a Parry Peak power cap for two nodes at the same time with a single command line invocation.

I also tested snapshots for all platforms using '--xnames all' to verify all URI's were valid.

Test description:

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? Yes
  • Were continuous integration tests run? Yes
  • Was upgrade tested? Yes via 'helm upgrade'
  • Was downgrade tested? Yes via 'helm rollback'

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable

@jwlv jwlv requested review from a team as code owners March 10, 2024 23:27
Copy link

👋 Hey! Here are the chart(s) we built for you:

Chart Download Link
cray-power-control-2.0.7-20240310232816+8f8cc2e.tgz https://artifactory.algol60.net/artifactory/csm-helm-charts/unstable/cray-hms-power-control/cray-power-control-2.0.7-20240310232816+8f8cc2e.tgz
cray-power-control-2.1.4-20240310232816+8f8cc2e.tgz https://artifactory.algol60.net/artifactory/csm-helm-charts/unstable/cray-hms-power-control/cray-power-control-2.1.4-20240310232816+8f8cc2e.tgz

Note: this SHA is the merge of d3254c7 and the PR base branch. Good luck and make rocket go now! 🌮 🚀

Build summary

Build metadata

Key Value
Artifactory Component cray-hms-power-control
Stable Build false
Unstable Build Prefix -20240310232816+8f8cc2e

Publish Helm charts results

Key Value
Status success
Successfully uploaded charts count 2
Failed uploaded charts count 0

@jwlv jwlv requested a review from mbuchmann-hpe March 10, 2024 23:30
@jwlv jwlv merged commit 0322e43 into main Mar 11, 2024
17 of 23 checks passed
@jwlv jwlv deleted the CASMHMS-6146 branch March 11, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants