CASMHMS-6146: Generate correct PowerCapURI for Olympus hardware #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
PCS has been using the older /Power redfish URL to generate PowerCapURI for /Controls.Deep on all Olympus hardware. The issue with that is that newer hardware (eg. Blanca Peak, Parry Peak) no longer have the /Power URL. The fix here is to take one of the Controls URLs (eg. /Controls/NodePowerLimit) and use it to construct the PowerCapURI for /Controls.Deep. For simplicity and clarity in the code, the fix does this for all Olympus hardware even though older hardware still have the /Power URL.
Additionally, two health checks in the power cap path were converted to check for this newly constructed PowerCapURI rather than key off the older /Power URL that no longer exists.
Adopted app version 2.2.0 for CSM 1.5 (helm chart 2.0.7)
Adopted app version 2.2.0 for CSM 1.6 (helm chart 2.1.4)
Issues and Related PRs
Testing
Tested on tyr against the Windom, Bard Peak, Blanca Peak, and Parry Peak platforms.
For Windom, Blanca Peak, and Parry Peak I set and cleared a power cap for "Power Node Limit"
For Bard Peak I set and cleared a power cap for "Accelerator3 Power Limit"
I also verified that I could set a Parry Peak power cap for two nodes at the same time with a single command line invocation.
I also tested snapshots for all platforms using '--xnames all' to verify all URI's were valid.
Test description:
Pull Request Checklist