Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMHMS-6324: Added support for ppprof builds #39

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jwlv
Copy link
Contributor

@jwlv jwlv commented Dec 23, 2024

Summary and Scope

Added support for pprof builds. Profiling adds runtime overhead so pprof support is not enabled by default. It is meant to be a debug tool. In order to enable pprof support, the following ARG in the Dockerfile should be changed from false to true:

ARG ENABLE_PPROF=true

After completing this step, rebuild the application and pprof support will be enabled after it is deployed.

Adopted app version 1.22.0 for CSM 1.6.1 (helm chart 3.0.3)

Issues and Related PRs

Testing

Tested on:

  • mug

Test description:

  • Deployed service with pprof enabled - confirmed pprof functionality
  • Deployed services with pprof disabled - confirmed pprof support not built into binary
  • Functional tests (if they exist) was successfully ran with and without pprof enabled

Test Checklist:

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? Y
  • Were continuous integration tests run? If not, why? Y
  • Was upgrade tested? If not, why? Y
  • Was downgrade tested? If not, why? Y

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable

@jwlv jwlv requested review from a team as code owners December 23, 2024 20:42
@jwlv jwlv requested review from jnowicki-hpe, shunr-hpe and mbuchmann-hpe and removed request for jnowicki-hpe December 23, 2024 20:42
Copy link

github-actions bot commented Dec 23, 2024

👋 Hey! Here are the chart(s) we built for you:

Chart Download Link
cray-power-control-2.1.11-20241223205644+20fab78.tgz https://artifactory.algol60.net/artifactory/csm-helm-charts/unstable/cray-hms-power-control/cray-power-control-2.1.11-20241223205644+20fab78.tgz

Note: this SHA is the merge of 31ccba7 and the PR base branch. Good luck and make rocket go now! 🌮 🚀

Build summary

Build metadata

Key Value
Artifactory Component cray-hms-power-control
Stable Build false
Unstable Build Prefix -20241223205644+20fab78

Publish Helm charts results

Key Value
Status success
Successfully uploaded charts count 1
Failed uploaded charts count 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants