Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set client_max_body_size to allow for larger sls loadstates #15

Merged
merged 1 commit into from
Aug 29, 2024
Merged

set client_max_body_size to allow for larger sls loadstates #15

merged 1 commit into from
Aug 29, 2024

Conversation

jacobsalmela
Copy link
Collaborator

Summary and Scope

Sets client_max_body_size in the nginx config to allow for larger client bodies. This specifically helps with large SLS loadstates, which are often needed when assisting customers.

<html>
<head><title>413 Request Entity Too Large</title></head>
<body>
<center><h1>413 Request Entity Too Large</h1></center>
<hr><center>nginx/1.27.1</center>
</body>
</html>

I arbitrarily set it to 5M based on a current dumpstate size + a buffer. It can be adjusted as needed going forward.

Issues and Related PRs

Testing

Loaded the simulator and posted a large SLS loadstate which previously failed with the HTTP 413 return code.

Tested on:

  • Local development environment

Risks and Mitigations

Low.

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@jacobsalmela jacobsalmela self-assigned this Aug 29, 2024
@jacobsalmela jacobsalmela marked this pull request as ready for review August 29, 2024 14:02
@jacobsalmela jacobsalmela requested review from a team as code owners August 29, 2024 14:02
@jacobsalmela jacobsalmela merged commit c036409 into develop Aug 29, 2024
3 checks passed
@jacobsalmela jacobsalmela deleted the maximum-colt branch August 29, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shunr-hpe shunr-hpe shunr-hpe approved these changes

@jnowicki-hpe jnowicki-hpe Awaiting requested review from jnowicki-hpe jnowicki-hpe is a code owner automatically assigned from Cray-HPE/hardware-management

Assignees

@jacobsalmela jacobsalmela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobsalmela @shunr-hpe