-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASMHMS-6299: Fix PCS/TRS resource leaks and scaling issues #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwlv
requested review from
mbuchmann-hpe
and removed request for
jacobsalmela
November 22, 2024 03:43
This was referenced Nov 22, 2024
callers shouldn't have access to it, especially if TRS requires them to read the responses
- Don't drain/close bodies that retryablehttp will handle - Allow retry counts of 0
Test closing idle connections to see if affects memory
Try forcing HTTP2
mbuchmann-hpe
approved these changes
Nov 25, 2024
mharding-hpe
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
A variety of changes, mostly in support of PCS experiencing scaling issues in the field. Details are as follows:
One thing to note about adding support for connections pools, this only provides the capability on the client side, for users of TRS. Remote servers (or intermediate firewalls, proxies, etc) may not be configured, or desire, to maintain open idle connections for a period of time. We discovered that while some BMCs kept connections open, others didn't.
The PCS PR needing these changes: Cray-HPE/hms-power-control#57
The PCS helm chart PR: Cray-HPE/hms-power-control-charts#38
Issues and Related PRs
Testing
Test description:
Testing was two-pronged, unit testing and testing on a live system. The majority of testing was done through the unit test framework. Extensive unit tests were added for all aspects of the connection lifecycle. Many of the tests are not run in the build pipeline because the build pipeline limits the total unit test time to 10 minutes. Developers making changes in the future should (a) enable/disable each test so that it can confirm no regressions, or (b) and probably more appropriately, move the connection unit tests into the integration test framework in the build pipeline.
These changes were also tested alongside PCS changes on both
mug
androcket
. Rocket is a CSM 1.5 system and mug is a CSM 1.6 system. Additionally, mug was running several thousand simulated BMCs on compute nodes so that the scaling aspects of these changes could be tested. All standard PCS operations were confirmed to continue working.While we do not have any systems internally that are able to reproduce all of the problems at customer sites, we believe this change will go a long ways towards improving most of the issues being experienced.
Testing Check List:
Pull Request Checklist