Tidy up metal-iptables.service

Adds a `ExecCondition` that checks whether our `/etc/iptables/metal.conf` file exists before trying to start. This will more clearly state why the service failed instead of leaving the `ExecStart` command output to the user to interpret. Alpha-sorts the properties.
Cray-HPE · Aug 10, 2024 · 27e606e · 27e606e
1 parent 68918aa
commit 27e606e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/roles/node_images_ncn_metal/files/systemd/metal-iptables.service b/roles/node_images_ncn_metal/files/systemd/metal-iptables.service
@@ -3,10 +3,11 @@ Description=Loads Metal iptables config
 After=local-fs.target network.service
 
 [Service]
-Type=oneshot
+ExecCondition=/bin/bash -c '[ -f /etc/iptables/metal.conf ]'
 ExecStart=/usr/sbin/iptables-restore /etc/iptables/metal.conf
 Restart=no
 RemainAfterExit=no
+Type=oneshot
 
 [Install]
 WantedBy=multi-user.target