CRAYSAT-1330: Specify image name directly in CFS session when possible #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haasken-hpe
changed the title
annapoorna-s-alt
approved these changes
Aug 9, 2024
shivaprasad-metimath
approved these changes
Aug 9, 2024
|
License check seems to be failing, need to update the year in the files |
haasken-hpe
force-pushed
the
CRAYSAT-1330-cfs-rename-parameter
branch
from
7c4df3c to
520f8ee
Compare
It just failed on the |
|
I do need a changelog update though, oops! |
Version 2.0.0 of `csm-api-client` introduces the ability to specify the name of images when images are customized in CFS.
When possible, specify the desired resulting image name directly when creating the CFS session instead of requiring a costly and failure-prone image rename operation after the CFS configuration has been completed. This greatly improves the reliability and performance of `sat bootprep` for image customization. Test Description: Not tested yet.
haasken-hpe
force-pushed
the
CRAYSAT-1330-cfs-rename-parameter
branch
from
520f8ee to
ec2a1fd
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
CRAYSAT-1330: Specify image name directly in CFS session when possible
When possible, specify the desired resulting image name directly when
creating the CFS session instead of requiring a costly and failure-prone
image rename operation after the CFS configuration has been completed.
This greatly improves the reliability and performance of
sat bootprepfor image customization.
Test Description:
Not tested yet.
CRAYSAT-1330: Update to version 2.0.0 of csm-api-client
Version 2.0.0 of
csm-api-clientintroduces the ability to specify thename of images when images are customized in CFS.
Issues and Related PRs
Testing
Tested on:
Test description:
Created a build of the sat container image and tested as follows:
Created a bootprep file that builds and customizes an image from the CSM barebones image. Also tested the same thing but with it building the image from recipe first.
Verified that the CFS session specified the destination image name, and that SAT didn't have to rename the image. Verified that the image existed afterwards.
Risks and Mitigations
This has the same risks as mentioned in Cray-HPE/python-csm-api-client#30
Pull Request Checklist